Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for alert repair/remediate #4084

Merged
merged 7 commits into from
Nov 9, 2018

Conversation

sumitabarahmand
Copy link
Contributor

@sumitabarahmand sumitabarahmand commented Oct 5, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link

msftclas commented Oct 5, 2018

CLA assistant check
All CLA requirements met.

@AutorestCI
Copy link

AutorestCI commented Oct 5, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Oct 5, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Oct 5, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Oct 5, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Oct 5, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@sumitabarahmand
Copy link
Contributor Author

@bganapa @deathly809

@AutorestCI
Copy link

AutorestCI commented Oct 5, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@bganapa
Copy link
Member

bganapa commented Oct 5, 2018

@sarangan12 This is going thru azure stack admin api review board, please wait for sign off from @deathly809 or @bganapa before merge

@sarangan12
Copy link
Member

@sumitabarahmand The semantic validator is failing. Please fix it.

@sarangan12 sarangan12 requested review from shahabhijeet and removed request for sarangan12 October 16, 2018 19:14
@bganapa
Copy link
Member

bganapa commented Oct 24, 2018

@sumitabarahmand Are you planning to take this in for the upcoming AZURESTACK release?

@bganapa
Copy link
Member

bganapa commented Nov 5, 2018

@shahabhijeet this should be good to merge

@bganapa
Copy link
Member

bganapa commented Nov 8, 2018

@shahabhijeet @sarangan12 , can one of you merge this pls, we had to update the SDK PR once this is merged.. Thanks!
Azure/azure-sdk-for-net#5000

@sarangan12 sarangan12 merged commit 3f568b4 into Azure:master Nov 9, 2018
lmazuel added a commit that referenced this pull request Nov 15, 2018
lmazuel added a commit that referenced this pull request Nov 15, 2018
* Revert "Add maximum chunk size to data lake store docs. (#4464)"

This reverts commit ab9c6ff.

* Revert "Add latest authorization tag to java config (#4406)"

This reverts commit 7f0fd16.

* Revert "Mdb 20181029 statepropdescriptions (#4452)"

This reverts commit 90db24c.

* Revert "fixing invalid location in examples (#4415)"

This reverts commit ffaf595.

* Revert "/identity endpoint added (#4460)"

This reverts commit 4f93dee.

* Revert "Added missing PATCH operation to Api Issue resource (#4440)"

This reverts commit 7df0ce5.

* Revert "Adds storage account quick failover API (#4457)"

This reverts commit 10ec74f.

* Revert "DataFactory: add table name in dataset (#4424)"

This reverts commit f8465de.

* Revert "Update README.md (#4421)"

This reverts commit fa6a584.

* Revert "Move Ruby SDK config to its own config file (#4451)"

This reverts commit 2ca50c8.

* Revert "[CognitiveServices] enable Bing Search/CustomSearch products to specify Endpoint (#4401)"

This reverts commit dc782b3.

* Revert "Add GeoRegion property to DeletedSite model (#4448)"

This reverts commit a079367.

* Revert "  Azure Container Instance: Add start container group API (#4423)"

This reverts commit 2ea3e9e.

* Revert "add guidance for example names (#4432)"

This reverts commit 6780e8a.

* Revert "Remove security contact phone field mandatory fields (#4417)"

This reverts commit eaf464e.

* Revert "Add Allowed Connections REST API (#4106)"

This reverts commit 2389da3.

* Revert "Make NIC VM readOnly (#4444)"

This reverts commit 2d83450.

* Revert "Remove readonly attribute from identities collection in users (#4442)"

This reverts commit 7577df9.

* Revert "Add spec for alert repair/remediate (#4084)"

This reverts commit 3f568b4.

* Revert "Py conf in its own file (#4439)"

This reverts commit 3373760.

* Revert "Split Python conf in it's own file (#4438)"

This reverts commit 77cf607.

* Revert "Adding ManagedInstanceVulnerabilityAssessments and ServerVulnerabilityAssessments (#4416)"

This reverts commit dec7549.

* Revert "WebApps: Snapshots API for DR stamps (#4291)"

This reverts commit 916ff2e.

* Revert "Swagger closure for Azure Migration Hub Operations (#4330)"

This reverts commit badd1de.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants